[HTML SKIN] Default-mod with fanart and localizations, v2.9.1.8 (final), updated May-20-2013

[Omertron]

Yes, there is some code in details.xsl and the watched folder (copy to your skin)

I think it only works on the 200 series atm, but it's being looked into to make it work on the 100 series

[nawo69]

(09-14-2011 10:15 AM)bassie112 Wrote:  Uploaded the final version (2.5.0.2 sep-14-2011) with a small correction. On index the score was shown incorrectly. Now everything should be ok.

The default skin has version 2.5.0 so the name of the modded skin says something about the version of the base skin. I added another version number to show changes made by me. 2.5.0.2 will be the final version until the default skin is updated or I get requests. I did not spot any bugs in this version, when you do please let me know.

Thanks for adding the Watched option back in.

The new version of the skin the Rating is not working properly for me; it is showing as 0.88 instead of 8.8 etc on both index and details pages

[bassie112]

(09-14-2011 12:02 PM)Omertron Wrote:  Yes, there is some code in details.xsl and the watched folder (copy to your skin)

I think it only works on the 200 series atm, but it's being looked into to make it work on the 100 series

Ok nice, then it should also work for this modded skin. When the default skin gets an update or the div-factor has been fixed I will update the skin. For now it works ok with 2648.

(09-14-2011 12:54 PM)nawo69 Wrote:  Thanks for adding the Watched option back in.

The new version of the skin the Rating is not working properly for me; it is showing as 0.88 instead of 8.8 etc on both index and details pages

Use the latest 2648 of YAMJ as this is a bug as explained by Omertron. When you want to use an older version of YAMJ you have to change back the div-factor (see page back) to 10 instead of 100 for both index.xsl and details.xsl.

[nawo69]

weird im getting different result to you:-

just tried a new jukebox with yamj 2468 and with just 2 films to test.

default skin = ratings show correctly and red button for marking watch/unwatched works

default-mod-small = ratings show with 0. in front ie 6.7 would be 0.67 and red button does not mark watched/unwatched.

(i tried removing RED from the tvid options in index.xsl and details.xsl but still didn't work)

[bassie112]

(09-14-2011 11:19 PM)nawo69 Wrote:  weird im getting different result to you:-

just tried a new jukebox with yamj 2468 and with just 2 films to test.

default skin = ratings show correctly and red button for marking watch/unwatched works

default-mod-small = ratings show with 0. in front ie 6.7 would be 0.67 and red button does not mark watched/unwatched.

(i tried removing RED from the tvid options in index.xsl and details.xsl but still didn't work)

Red button: did not know about this functionality. Set the same tvid as the default skin and it should be ok. Just removing it will not bring this functionality back probably. Tomorrow I will make a new update with the same tvid's as the default skin!

Ratings: have you replaced the div 100 with div 10 for index.xsl and details.xsl? Should work. Tomorrow I will look into it. Btw have you completely removed all previous data for YAMJ? Otherwise it may still use some data from the old YAMJ.

[nawo69]

(09-14-2011 11:27 PM)bassie112 Wrote:  

(09-14-2011 11:19 PM)nawo69 Wrote:  weird im getting different result to you:-

just tried a new jukebox with yamj 2468 and with just 2 films to test.

default skin = ratings show correctly and red button for marking watch/unwatched works

default-mod-small = ratings show with 0. in front ie 6.7 would be 0.67 and red button does not mark watched/unwatched.

(i tried removing RED from the tvid options in index.xsl and details.xsl but still didn't work)

Red button: did not know about this functionality. Set the same tvid as the default skin and it should be ok. Just removing it will not bring this functionality back probably. Tomorrow I will make a new update with the same tvid's as the default skin!

Ratings: have you replaced the div 100 with div 10 for index.xsl and details.xsl? Should work. Tomorrow I will look into it. Btw have you completely removed all previous data for YAMJ? Otherwise it may still use some data from the old YAMJ.

ive got the ratings sorted thanks thought you only had to edit the div bit if using an older version of yamj sorry must of misread

[bassie112]

(09-14-2011 11:53 PM)nawo69 Wrote:  

(09-14-2011 11:27 PM)bassie112 Wrote:  

(09-14-2011 11:19 PM)nawo69 Wrote:  weird im getting different result to you:-

just tried a new jukebox with yamj 2468 and with just 2 films to test.

default skin = ratings show correctly and red button for marking watch/unwatched works

default-mod-small = ratings show with 0. in front ie 6.7 would be 0.67 and red button does not mark watched/unwatched.

(i tried removing RED from the tvid options in index.xsl and details.xsl but still didn't work)

Red button: did not know about this functionality. Set the same tvid as the default skin and it should be ok. Just removing it will not bring this functionality back probably. Tomorrow I will make a new update with the same tvid's as the default skin!

Ratings: have you replaced the div 100 with div 10 for index.xsl and details.xsl? Should work. Tomorrow I will look into it. Btw have you completely removed all previous data for YAMJ? Otherwise it may still use some data from the old YAMJ.

ive got the ratings sorted thanks thought you only had to edit the div bit if using an older version of yamj sorry must of misread

No you have read it right. Maybe the issue had something to do with a certain parameter in the yamj properties file. For now: of it works, ok, otherwise edit the div factor.

[bassie112]

Ok, I made a new version with the same TVID's as the default skin. So the watched button should work.. please let me know.

Another thing about the ratings:
When you scrape movie info you have to use div 10 or the score will show up as 0.xx instead of x.x.
When you don't scrape or use NFO's you have to use div 100 or the score will show up as xx instad of x.x.

So there is something wrong woth the nfo-scanner. I will make 2 versions for the time being. 1 for scraping, 1 for nfo's.

[nawo69]

(09-15-2011 12:16 PM)bassie112 Wrote:  Ok, I made a new version with the same TVID's as the default skin. So the watched button should work.. please let me know.

Another thing about the ratings:
When you scrape movie info you have to use div 10 or the score will show up as 0.xx instead of x.x.
When you don't scrape or use NFO's you have to use div 100 or the score will show up as xx instad of x.x.

So there is something wrong woth the nfo-scanner. I will make 2 versions for the time being. 1 for scraping, 1 for nfo's.

Excellent will test watched tonight when I get in.

Yeah I used nfo's so that why I was having the problem.

Thanks mate.

[bassie112]

(09-15-2011 01:51 PM)nawo69 Wrote:  

(09-15-2011 12:16 PM)bassie112 Wrote:  Ok, I made a new version with the same TVID's as the default skin. So the watched button should work.. please let me know.

Another thing about the ratings:
When you scrape movie info you have to use div 10 or the score will show up as 0.xx instead of x.x.
When you don't scrape or use NFO's you have to use div 100 or the score will show up as xx instad of x.x.

So there is something wrong woth the nfo-scanner. I will make 2 versions for the time being. 1 for scraping, 1 for nfo's.

Excellent will test watched tonight when I get in.

Yeah I used nfo's so that why I was having the problem.

Thanks mate.

I use NFO's too but I have scrapeLibrary=false in My_Library.xml. Probably that parameter is the deciding factor. It has something to do with nfo's and/or scraping, but at least there are 2 versions so 1 should work .

[nawo69]

just tested the watched feature and nearly working

Press Red on unwatched film it creates a .watched file but it doesn't change to Watched: Yes even after rerunning yamj

Press Red on watched film the .watched file isn't deleted

both ok with default skin.

[Omertron]

Rating issue logged: http://code.google.com/p/moviejukebox/is...il?id=2087

Please watch that issue, I'll mark it as fixed when it's done.

In the future, if you come across strange anomalies like this, please log an issue and we can look into it. There's no need for you to write two versions of the skin to cope with this sort of bug.

[bassie112]

(09-16-2011 01:56 PM)Omertron Wrote:  Rating issue logged: http://code.google.com/p/moviejukebox/is...il?id=2087

Please watch that issue, I'll mark it as fixed when it's done.

In the future, if you come across strange anomalies like this, please log an issue and we can look into it. There's no need for you to write two versions of the skin to cope with this sort of bug.

No problem!

---

(09-15-2011 06:33 PM)nawo69 Wrote:  just tested the watched feature and nearly working

Press Red on unwatched film it creates a .watched file but it doesn't change to Watched: Yes even after rerunning yamj

Press Red on watched film the .watched file isn't deleted

both ok with default skin.

You are right. I fixed it and new version (4) is up. However there are 2 things I can't fix due to the dynamic nature of the watched script.
1. Translation of the word true/false/yes/no for "watched" on the details-page
2. A watched indicator on the index-page

Tried some stuff but I can't fix these. If somebody knows how to put a watched-indicator on the index-page, just like the details-page, let me know. Also if you know how to incorporate a translation of true/false/yes/no for "watched" on the details-page let me know.

[jluc2808]

translation of true/false/yes/no for "watched" on the details-page

open the script and change Yes/no to what word you would like

[bassie112]

(09-16-2011 04:08 PM)jluc2808 Wrote:  translation of true/false/yes/no for "watched" on the details-page

open the script and change Yes/no to what word you would like

Indeed that works, but I was looking for a solution on the skin-side. But thanks.